Add test and update documentation for using anyOf inside array items #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glasserc If you have time a review would be great! |
glasserc
approved these changes
Jan 18, 2019
epicfaace
requested changes
Jan 19, 2019
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
|
@epicfaace I've addressed your review comments, could you take another look at this PR please? |
epicfaace
approved these changes
Jan 21, 2019
|
Looks good, thanks @LucianBuzzo ! |
9 tasks
KeroVieux
added a commit
to KeroVieux/react-jsonschema-form
that referenced
this pull request
Jan 25, 2019
* 'master' of github.com:KeroVieux/react-jsonschema-form: updated replace submit button paragraph tag with div (rjsf-team#766) Fixes rjsf-team#824 (rjsf-team#1147) Fix bug where matching anyOf branch is not selected correctly (rjsf-team#1129) Document a gotcha with `additionalProperties` (rjsf-team#1149) doc: add permalinks and fix internal hyperlinks in documentation doc: add doc build instructions, update PR/issue templates with doc links Add onBlur and onFocus events for radio and checkbox widgets (rjsf-team#1143) add ui:help tips (rjsf-team#1145) doc: fix browserstack logo size docs: remove docs from README and link to readthedocs rjsf-team#1138 doc: organize docs into separate files rjsf-team#1138 doc: add browserstack logo rjsf-team#990 Add test and update documentation for using anyOf inside array items (rjsf-team#1131) # Conflicts: # src/components/Form.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucian lucian.buzzo@gmail.com
I'd previously made the incorrect assumption that #1118 would not automatically work with array items - upon investigation I found that it just works™.
This PR just adds a basic test case for array support, updates the documentation and adds to the examples.
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style